xds: Use XdsDependencyManager for XdsNameResolver#11957
Merged
ejona86 merged 5 commits intogrpc:masterfrom Mar 18, 2025
Merged
Conversation
ejona86
commented
Mar 12, 2025
Member
Author
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
These replies are just for posterity. We discussed in-person.
Contributes to the gRFC A74 effort. https://github.com/grpc/proposal/blob/master/A74-xds-config-tears.md Co-authored-by: Eric Anderson <ejona@google.com>
The alternative to using Mockito's ArgumentMatcher is to use Hamcrest. However, Hamcrest did not impress me. ArgumentMatcher is trivial if you don't care about the error message.
This fixes a pre-existing issue where ConfigSelector.releaseCluster could revert the LB config back to using cluster manager after releasing all RPCs using a cluster have committed.
Unused since the context string was included directly into Data's StatusOr
Member
Author
|
I saw there's still a new TODO for a test, but I'll look at that later. |
larry-safran
approved these changes
Mar 18, 2025
| } | ||
|
|
||
| static final class StringContainsMatcher implements ArgumentMatcher<String> { | ||
| private final String needle; |
Contributor
There was a problem hiding this comment.
I like the variable names :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm going to leave this in draft form until after I squash and rebase on master (once the review has gotten to that point).
"Gracefully handle tcp listeners. Fix error processing in XdsNR" is partly speculative right now, as we have a discussion of how error handling should be done. The tcp listeners is needed, but it got mixed together with onError() behavior. I can split it up needed.The gRFC changed to match the behavior here. grpc/proposal@fea3788